Support @IdGeneratorType #2380
Support @IdGeneratorType #2380
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| @Override | ||
| default Id generate( |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| } | ||
|
|
||
| @Override | ||
| default Object generate(SharedSessionContractImplementor session, Object object){ |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
DavideD
left a comment
DavideD
left a comment
There was a problem hiding this comment.
Thanks!
I gave it a quick look, but I will check better tomorrow
| public void testPersist(VertxTestContext context) { | ||
| Person person = new Person(); | ||
| test( | ||
| context, openSession() |
There was a problem hiding this comment.
Could you use getMutinySessionFactory.withTransaction?
I think it's more similar to a typical use case.
Maybe we could also test without transactions, but we should at least add a comment to explain what's going on
There was a problem hiding this comment.
Would it make sense to also read the value from the database to make sure that they match? Maybe it's overkill
| context, openSession() | ||
| .thenCompose( session -> session.persist( person ) ) | ||
| .thenAccept( v -> { | ||
| assertThat( person.getId() ).isNotNull(); |
There was a problem hiding this comment.
I just realized that this test is wrong because the id is a primitive type so it's never going to be null
|
I will send a PR rebased to the latest changes |
2 participants
Fix #1906